Improve access checking code #4317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
reviewed
Sep 16, 2024
auto-merge was automatically disabled
September 17, 2024 16:26
Head branch was pushed to by a user without write access
|
Seems like this was failing because of some line changes, sorry about that. |
|
No worries! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
This change accomplishes the TODOs for access checking. More specifically it, - makes `SemIR::AccessKind` formattable using `llvm::formatv`. - makes use of `LookupUnqualifiedName` to find `Self`.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
hamphet
pushed a commit
to hamphet/carbon-lang
that referenced
this pull request
Sep 18, 2024
This change accomplishes the TODOs for access checking. More specifically it, - makes `SemIR::AccessKind` formattable using `llvm::formatv`. - makes use of `LookupUnqualifiedName` to find `Self`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change accomplishes the TODOs for access checking. More specifically it,
SemIR::AccessKindformattable usingllvm::formatv.LookupUnqualifiedNameto findSelf.