Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how CheckParseTrees receives NodeLocConverters #4563

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Nov 21, 2024

This is really a set of closely related changes:

  1. We really shouldn't be creating a Check::Unit for Lower. This fixes that by storing the diagnostic converter for reuse.
  2. Rather than passing in node converters to Check as their own array, pass diagnostic converters as part of Check::Unit.
  3. To support creating the converters early, pass SemIR::File pre-constructed.
  4. Since SemIR::File construction was used to track "checked", add is_checked for that.
  5. Clarifies a subtle edge case around input_filename_ use with -.

Note the key consequence of this change, where I actually started, is that Check only has one array of Check::Unit instead of receiving NodeLocConverter as a separate array.

@jonmeow jonmeow force-pushed the check-node-converter branch 2 times, most recently from 996bd77 to f049a32 Compare November 21, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant