Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to pyproject.toml #127

Merged
merged 12 commits into from
Dec 19, 2024
Merged

Transition to pyproject.toml #127

merged 12 commits into from
Dec 19, 2024

Conversation

norlandrhagen
Copy link
Collaborator

@norlandrhagen norlandrhagen commented Dec 19, 2024

Makes some updates in hopes of fixing the failing CI.

  • replaced setup.cfg & setup.py with pyproject.toml
  • updates linting to ruff
  • builds a bit of python package structure.
  • Adds python install to CI.

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
compliance-users ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 7:00pm

Copy link
Member

@katamartin katamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you @norlandrhagen

Tagging in @badgley and @freyac to make sure this looks good to them as the maintainers of the Python scripts!

@katamartin katamartin requested review from badgley and freyac December 19, 2024 16:19
@norlandrhagen
Copy link
Collaborator Author

Minor CI Q for you @katamartin, in the npm CI bit, should the node version be updated or kept as is? node-version: [14.x, 16.x] -> node-version: [18.x, 20.x]

@norlandrhagen
Copy link
Collaborator Author

Tagging in @badgley and @freyac to make sure this looks good to them as the maintainers of the Python scripts!

If one of you wants to give this change a spin, you can install the library (in a clean env) with:
pip install -e .
or
pip install -e '.[test]' # which will give you pre-commit, pytest etc.

@katamartin
Copy link
Member

Minor CI Q for you @katamartin, in the npm CI bit, should the node version be updated or kept as is? node-version: [14.x, 16.x] -> node-version: [18.x, 20.x]

Great Q, ty! It'd be great to do that update because Vercel is already building on 18.x, and it'd be good to keep an eye on 20.x.

@freyac
Copy link
Member

freyac commented Dec 19, 2024

Looks good to me. Thank you so much, @norlandrhagen !

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
norlandrhagen and others added 4 commits December 19, 2024 13:58
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
norlandrhagen and others added 2 commits December 19, 2024 13:59
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
@norlandrhagen norlandrhagen merged commit c76840c into main Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants