-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial attempt at citation.cff for forest risks #56
base: main
Are you sure you want to change the base?
Conversation
citation.cff
Outdated
year: 2021 | ||
journal: bioRxiv | ||
URL: https://www.biorxiv.org/content/early/2021/05/13/2021.05.11.443688 | ||
publisher: Cold Spring Harbor Laboratory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publisher: Cold Spring Harbor Laboratory | |
publisher: Cold Spring Harbor Laboratory |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this extra indentation intentional?
citation.cff
Outdated
- name: "CarbonPlan Team" | ||
- name: "Bill Anderegg (@anderegg)" | ||
- name: "Grayson Badgley (@badgley)" | ||
- name: "Anna Trugman" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use the full author list here: https://doi.org/10.5281/zenodo.4741328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add orcid fields
citation.cff
Outdated
value: https://doi.org/10.5281/zenodo.4741328 | ||
- description: "forest-risks (data) Zenodo archive" | ||
type: doi | ||
value: https://doi.org/10.5281/zenodo.4741332 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what to do here. is this all we can add, or can we also add a description / authors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the author list as well as the description from Zenodo. I think we can add a bunch of fields.
https://github.com/citation-file-format/citation-file-format/blob/main/schema-guide.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super helpful. I don't see repository
as a key that takes a mapping though. So I think we need to rethink this section a bit. I'll write up some broader thoughts on the way this may go above.
Co-authored-by: Joe Hamman <jhamman1@gmail.com>
Co-authored-by: Joe Hamman <jhamman1@gmail.com>
Co-authored-by: Joe Hamman <jhamman1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close!
I think we basically want 3 blocks:
- main section (point to zenodo doi)
- preferred citation (I think this is fine as is)
- references section (links to related works, i.e. risks dataset).
So I think you are basically missing the references section (maybe just a type repository->references?)
citation.cff
Outdated
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra blank lines (1 is okay)
citation.cff
Outdated
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra blank lines (1 is okay)
citation.cff
Outdated
value: https://doi.org/10.5281/zenodo.4741328 | ||
- description: "forest-risks (data) Zenodo archive" | ||
type: doi | ||
value: https://doi.org/10.5281/zenodo.4741332 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super helpful. I don't see repository
as a key that takes a mapping though. So I think we need to rethink this section a bit. I'll write up some broader thoughts on the way this may go above.
citation.cff
Outdated
given-names: "Joseph J." | ||
orcid: https://orcid.org/0000-0001-7479-8439 | ||
license: MIT, CC-BY-4.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add repository-code
field here.
No description provided.