-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
References updates #12
Conversation
This looks really clean to me! And super excited for this functionality. Only one question: what happens when a reference is repeated twice? I'm not sure we'll have this often (or ever), but I seem to recall we've avoided it because we were worried it would screw things up. From a rendering standpoint, I think what we want is if |
Also rename CiteInner sx props for consistency
Also use single hide prop to handle hiding inline reference
Ah good question! I added in a Also while I was touching the logic that handles groups of IDs, I tweaked the mobile rendering so that all references can be opened inline: Previously, this was rendered using |
lgtm! and very nice tweak for mobile, that's smart |
This PR makes a few updates to the way references are tracked in order to support some additional features:
Cite
/Sidenote
s are renderedreferences.js
numbered the references based on the order in which they were threaded through toReferencesProvider
. This (1) relied on object ordering and (2) required consumers to manually sort the references object.PrintedFootnotes
section to the bottom ofArticle
which displays a list of references using theEndnote
layout (isolated to printing using'@media print'
)references
and two inlineSidenote
s).Sidenote
componentcloses carbonplan/research#205