Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor endpoints for improved readability and maintenance #116

Merged
merged 18 commits into from
Aug 19, 2024

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Aug 16, 2024

this PR transitions the logic in our endpoints from a mix of SQL and Pandas to pure SQL using SQLAlchemy/SQLModel constructs for improved readability and maintenance

@github-actions github-actions bot added the api label Aug 16, 2024
@andersy005 andersy005 marked this pull request as ready for review August 19, 2024 21:10
@andersy005 andersy005 changed the title use subqueries instead of joins for improved readability and maintainance refactor endpoints for improved readability and maintenance Aug 19, 2024
@andersy005 andersy005 merged commit 48a2a17 into main Aug 19, 2024
4 of 5 checks passed
@andersy005 andersy005 deleted the use-subqueries-instead-of-joins branch August 19, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant