Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use none as filter value for registry deselection #49

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Oct 31, 2023

@katamartin, the simplest approach was to enable none as a filter value. let me know if this fulfills the requirements of the front-end.

❯ http 'https://offsets-db-staging.fly.dev/projects/?registry=none'                                                                                                                                           ─╯
HTTP/1.1 200 OK
content-encoding: gzip
content-type: application/json
date: Tue, 31 Oct 2023 14:28:32 GMT
fly-request-id: 01HE325PW34MYXQ3K8VGSPYQJW-lax
server: Fly/7328d5b5 (2023-10-27)
transfer-encoding: chunked
via: 1.1 fly.io

{
    "data": [],
    "pagination": {
        "current_page": 1,
        "next_page": null,
        "total_entries": 0,
        "total_pages": 0
    }
}

@github-actions github-actions bot added the api label Oct 31, 2023
@andersy005 andersy005 temporarily deployed to staging October 31, 2023 13:56 — with GitHub Actions Inactive
@andersy005 andersy005 merged commit d8c4fff into main Oct 31, 2023
4 checks passed
@andersy005 andersy005 deleted the handle-unexpected-filters branch October 31, 2023 14:29
@katamartin
Copy link
Member

Working perfectly, thanks @andersy005 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent handling of "unexpected" filtering
2 participants