Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bech32 decoder + encoder #312

Merged
merged 8 commits into from
May 24, 2019
Merged

Fix Bech32 decoder + encoder #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8f6e00a
Rewrite Bech32 encoder and decoder in terms of base-32 (Word5) strings.
jonathanknowles May 23, 2019
a997218
Add functions to convert `DataPart` to and from `Text`, using the Bec…
jonathanknowles May 24, 2019
0a6957a
Rename `mkHumanReadablePart` to `humanReadablePartFromBytes`.
jonathanknowles May 23, 2019
ce734e0
Remove unnecessary `bech32` prefix from functions within `Bech32.Inte…
jonathanknowles May 23, 2019
5b4d574
Wrap code to meet coding standards.
jonathanknowles May 23, 2019
ec0b86f
Encode to and decode from `Text` instead of `ByteString`.
jonathanknowles May 24, 2019
d7e9762
Fix a previously undetected bug in the specification.
jonathanknowles May 24, 2019
5617740
Don't convert to lower-case before calling `humanReadablePartFromText`.
jonathanknowles May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/bech32/bech32.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ library
, base
, bytestring
, extra
, text
hs-source-dirs:
src
exposed-modules:
Expand Down Expand Up @@ -61,6 +62,7 @@ test-suite bech32-test
, hspec
, bytestring
, QuickCheck
, text
main-is:
Main.hs
other-modules:
Expand Down
13 changes: 10 additions & 3 deletions lib/bech32/src/Codec/Binary/Bech32.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,17 @@ module Codec.Binary.Bech32
encode
, decode

-- * Human-Readable Parts
-- * Data Part
, DataPart
, dataPartFromBytes
, dataPartFromText
, dataPartToBytes
, dataPartToText

-- * Human-Readable Part
, HumanReadablePart
, mkHumanReadablePart
, humanReadablePartToBytes
, humanReadablePartFromText
, humanReadablePartToText

) where

Expand Down
Loading