Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3479] Update fake data for UI testing #4841

Merged
merged 5 commits into from
Nov 14, 2024
Merged

[ADP-3479] Update fake data for UI testing #4841

merged 5 commits into from
Nov 14, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Nov 14, 2024 •
edited
Loading

  • Fix a bug in the discretization lib
  • Remove fake deposits data for the UI
  • Add 1 mock transaction with 1M ada on the first customer in the deposit state at boot time to test payments page

ADP-3479

@paolino paolino changed the base branch from master to paolino/ADP-3479/split-pure-module November 14, 2024 13:17
@paolino paolino self-assigned this Nov 14, 2024
@paolino paolino added Deposit UI UI related changes labels Nov 14, 2024
Base automatically changed from paolino/ADP-3479/split-pure-module to master November 14, 2024 14:33
@paolino paolino force-pushed the paolino/ADP-3479/change-UI-mocking-strategy-to-test-payments-page branch from 030f058 to 8e5a75c Compare November 14, 2024 14:43
@paolino
Add mock funding to deposit wallet
c7c0a24
@paolino
Fix discretization lib bug
bf8d0e9 
It was returning values in the past for `nextDiscretizedTime`
I also added properties that ensure that `nextDiscretizeTime`
- returns values in the future
- that a next discretized time of a discretized time can be reverted by just discretizing the second before the next discretized time
@paolino
Remove fake data from the deposit wallet ui
63ead70
@paolino
Add temporary logging of the mocked initial deposit wallet state
c454a87
@paolino paolino force-pushed the paolino/ADP-3479/change-UI-mocking-strategy-to-test-payments-page branch from 8e5a75c to c454a87 Compare November 14, 2024 14:46
HeinrichApfelmus
HeinrichApfelmus approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊

@paolino paolino added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit b49617f Nov 14, 2024
24 checks passed
@paolino paolino deleted the paolino/ADP-3479/change-UI-mocking-strategy-to-test-payments-page branch November 14, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Deposit UI UI related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus