Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3479] Add XPrv management in deposit wallet REST interface #4842

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[ADP-3479] Add XPrv management in deposit wallet REST interface #4842

merged 2 commits into from
Nov 15, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Nov 15, 2024

@paolino paolino self-assigned this Nov 15, 2024
@paolino paolino added Deposit UI UI related changes labels Nov 15, 2024
HeinrichApfelmus
HeinrichApfelmus approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 😊 Before merging — could you add a test for credentialsFromMnemonics that checks whether XPrv + passphrase works with the generated XPub? This is the thing that we were unsure about.

lib/customer-deposit-wallet/http/Cardano/Wallet/Deposit/HTTP/Server.hs Outdated Show resolved Hide resolved
lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/Pure/State/Creation.hs Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3479/add-xprv-mgmt-to-deposit-REST-interface branch from 987ef79 to 1509e26 Compare November 15, 2024 17:10
@paolino paolino added this pull request to the merge queue Nov 15, 2024
Merged via the queue into master with commit b639cc7 Nov 15, 2024
24 checks passed
@paolino paolino deleted the paolino/ADP-3479/add-xprv-mgmt-to-deposit-REST-interface branch November 15, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Deposit UI UI related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus