Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): linking of ipex flows to contacts #422

Merged
merged 21 commits into from
Jul 31, 2024
Merged

feat(core): linking of ipex flows to contacts #422

merged 21 commits into from
Jul 31, 2024

Conversation

Sotatek-HocNguyena
Copy link
Collaborator

@Sotatek-HocNguyena Sotatek-HocNguyena commented Apr 16, 2024 •
edited
Loading

Description

  • Save the IPEX messages after interacting with them.
  • Create a method to return IPEX messages from other connections

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)

@Sotatek-HocNguyena Sotatek-HocNguyena self-assigned this Apr 16, 2024
@Sotatek-HocNguyena Sotatek-HocNguyena marked this pull request as ready for review April 16, 2024 08:28
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-q8jtznsbd.vercel.app

@Sotatek-HocNguyena Sotatek-HocNguyena changed the base branch from feat/DTIS-680-credential-server-api-rework to develop June 20, 2024 10:21
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-gqt4fyk5d.vercel.app

iFergal
iFergal reviewed Jun 24, 2024
View reviewed changes
src/core/agent/agent.types.ts Outdated Show resolved Hide resolved
src/core/agent/agent.types.ts Outdated Show resolved Hide resolved
src/core/agent/agent.types.ts Outdated Show resolved Hide resolved
src/core/agent/records/ipexMessageStorage.ts Show resolved Hide resolved
src/core/agent/services/connectionService.test.ts Show resolved Hide resolved
src/core/agent/services/connectionService.ts Outdated Show resolved Hide resolved
src/core/agent/services/ipexCommunicationService.ts Outdated Show resolved Hide resolved
@Sotatek-TungNguyen2a
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
5cd3036 
…allet into feature/DTIS-724-linking-of-IPEX-flows-to-contacts
@Sotatek-TungNguyen2a
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
44c7d0f 
…allet into feature/DTIS-724-linking-of-IPEX-flows-to-contacts
@Sotatek-TungNguyen2a
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
cc73acd 
…allet into feature/DTIS-724-linking-of-IPEX-flows-to-contacts
@Sotatek-TungNguyen2a
feat: linking of IPEX flows to contacts
0caf0a4
@Sotatek-TungNguyen2a Sotatek-TungNguyen2a self-assigned this Jul 29, 2024
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-kces8uk0v.vercel.app

iFergal
iFergal reviewed Jul 29, 2024
View reviewed changes
src/core/agent/records/ipexMessageRecord.ts Outdated Show resolved Hide resolved
src/core/agent/records/ipexMessageRecord.ts Outdated Show resolved Hide resolved
src/core/agent/services/connectionService.ts Outdated Show resolved Hide resolved
src/core/agent/services/connectionService.ts Outdated Show resolved Hide resolved
src/core/agent/services/connectionService.ts Outdated Show resolved Hide resolved
src/core/agent/services/signifyNotificationService.ts Show resolved Hide resolved
src/core/agent/agent.types.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-dhbnnj441.vercel.app

iFergal
iFergal reviewed Jul 29, 2024
View reviewed changes
src/core/agent/records/ipexMessageRecord.ts Outdated Show resolved Hide resolved
src/core/agent/services/connectionService.ts Outdated Show resolved Hide resolved
src/core/agent/services/signifyNotificationService.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-cr0kihe4k.vercel.app

iFergal
iFergal reviewed Jul 29, 2024
View reviewed changes
src/core/agent/services/connectionService.ts Outdated Show resolved Hide resolved
src/core/agent/services/ipexCommunicationService.ts Show resolved Hide resolved
services/credential-server/package-lock.json Outdated Show resolved Hide resolved
src/core/agent/records/ipexMessageStorage.ts Show resolved Hide resolved
src/core/agent/services/connectionService.test.ts Outdated Show resolved Hide resolved
src/core/agent/services/ipexCommunicationService.ts Show resolved Hide resolved
src/core/agent/services/signifyNotificationService.test.ts Outdated Show resolved Hide resolved
src/core/agent/services/ipexCommunicationService.ts Outdated Show resolved Hide resolved
src/core/agent/services/signifyNotificationService.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-27pa32sb1.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-nmki499u8.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-agfyaudpy.vercel.app

@iFergal iFergal merged commit eb1932f into develop Jul 31, 2024
1 check passed
@iFergal iFergal deleted the feature/DTIS-724-linking-of-IPEX-flows-to-contacts branch July 31, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a Sotatek-TungNguyen2a left review comments

@iFergal iFergal iFergal approved these changes

@Sotatek-BaoHoanga Sotatek-BaoHoanga Awaiting requested review from Sotatek-BaoHoanga

Assignees

@Sotatek-HocNguyena Sotatek-HocNguyena

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sotatek-HocNguyena @iFergal @Sotatek-TungNguyen2a @Sotatek-BaoHoanga