Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): max login attempts tracking (core only) #566

Merged
merged 7 commits into from
Jul 15, 2024
Merged

feat(core): max login attempts tracking (core only) #566

merged 7 commits into from
Jul 15, 2024

Conversation

Sotatek-BaoHoanga
Copy link
Collaborator

Description

Max login attempts tracking (core only)

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-mnikqbzob.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-lw8an7ar4.vercel.app

@Sotatek-BaoHoanga Sotatek-BaoHoanga marked this pull request as ready for review July 11, 2024 03:03
@iFergal iFergal self-requested a review July 11, 2024 07:33
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-y79duq9a2.vercel.app

@iFergal iFergal changed the title feat(core): Max login attempts tracking (core only) feat(core): max login attempts tracking (core only) Jul 11, 2024
iFergal
iFergal reviewed Jul 11, 2024
View reviewed changes
src/core/agent/agent.types.ts Outdated Show resolved Hide resolved
src/core/agent/services/authService.ts Outdated Show resolved Hide resolved
src/core/agent/services/authService.ts Outdated Show resolved Hide resolved
src/core/agent/services/authService.ts Outdated Show resolved Hide resolved
src/core/agent/services/authService.ts Outdated Show resolved Hide resolved
src/core/agent/services/authService.test.ts Show resolved Hide resolved
src/core/agent/services/authService.test.ts Show resolved Hide resolved
src/core/agent/services/authService.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-20zve1ozf.vercel.app

@iFergal iFergal merged commit bbfc5ac into develop Jul 15, 2024
1 check passed
@iFergal iFergal deleted the feat/DTIS-929-max-login-attempts-tracking branch July 15, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iFergal iFergal iFergal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sotatek-BaoHoanga @iFergal