Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Notification Management (clicking on Notification) #572

Merged
merged 11 commits into from
Jul 15, 2024

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Jul 11, 2024

Description

Implement advanced functionalities for the notifications screen to allow users to interact with, manage, and filter notifications efficiently

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-942

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

UI
Screenshot 2024-07-11 at 16 19 10 Screenshot 2024-07-11 at 16 19 16
Function
Screen.Recording.2024-07-11.at.15.54.46.mov

Android

UI

Screenshot 2024-07-11 at 16 15 28

Screenshot 2024-07-11 at 16 15 31

Function
Screen.Recording.2024-07-11.at.16.02.19.mov

Browser

UI

Screenshot 2024-07-11 at 16 21 07

Screenshot 2024-07-11 at 16 21 11

Function
Screen.Recording.2024-07-11.at.15.05.30.mov
Infinite load for earlier notification
Screen.Recording.2024-07-11.at.14.56.59.mov

@Sotatek-DukeVu Sotatek-DukeVu self-assigned this Jul 11, 2024
@Sotatek-DukeVu Sotatek-DukeVu marked this pull request as draft July 11, 2024 08:12
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-pibtqv5zi.vercel.app

@Sotatek-DukeVu Sotatek-DukeVu marked this pull request as ready for review July 11, 2024 09:28
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, also please make sure the NotificationDetails (as a page) and the modal are both updated to be compatible with back hardware button on Android.

src/ui/pages/Notifications/NotificationItem.tsx Outdated Show resolved Hide resolved
src/ui/pages/Notifications/NotificationItem.tsx Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@Sotatek-DukeVu
Copy link
Collaborator Author

Added a few comments, also please make sure the NotificationDetails (as a page) and the modal are both updated to be compatible with back hardware button on Android.

Update evidence

Screen.Recording.2024-07-12.at.15.52.13.mov

sdisalvo-crd
sdisalvo-crd previously approved these changes Jul 12, 2024
@Sotatek-DukeVu Sotatek-DukeVu force-pushed the feature/DTIS-942-notification-management branch from add752c to 10aab3a Compare July 15, 2024 08:16
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-qjm2ouurl.vercel.app

@sdisalvo-crd sdisalvo-crd merged commit bf20971 into develop Jul 15, 2024
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feature/DTIS-942-notification-management branch July 15, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants