Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): multisig receive acdc #590

Merged
merged 36 commits into from
Aug 7, 2024
Merged

feat(core): multisig receive acdc #590

merged 36 commits into from
Aug 7, 2024

Conversation

Sotatek-HocNguyena
Copy link
Collaborator

Description

Receive an ACDC to a multi-sig wallet

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Sotatek-HocNguyena and others added 28 commits June 28, 2024 16:21
@Sotatek-HocNguyena
feat: create multi-sig oobi
1e44923
@Sotatek-HocNguyena
Merge branch 'develop' of
4cc5a0e 
github.com:cardano-foundation/cf-identity-wallet into
feat/multisig-receive-acdc
@Sotatek-HocNguyena
feat: multisig admit credential
d71ce44
@Sotatek-HocNguyena
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
8864913 
…allet into feat/create-multi-sig-oobi
@Sotatek-HocNguyena
feat: creat multi-sig oobi
a4e5723
@Sotatek-HocNguyena
feat: creat multi-sig oobi
1ea9e22
@Sotatek-HocNguyena
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
574f9d4 
…allet into feat/create-multi-sig-oobi
@Sotatek-HocNguyena
feat: auto trigger end role authorization when the multisig is ready
6df90b3
@Sotatek-HocNguyena
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
12ffda5 
…allet into feat/create-multi-sig-oobi
@Sotatek-HocNguyena
refactor: get recp and ourAid outside the loop
8f0a6bc
@Sotatek-HocNguyena
Merge branch 'feat/create-multi-sig-oobi' of github.com:cardano-found…
9fe136a 
…ation/cf-identity-wallet into feat/multisig-receive-acdc
@Sotatek-HocNguyena
refactor: only join the authorization when the route is add end role
71d24dd
@Sotatek-HocNguyena
Merge branch 'feat/create-multi-sig-oobi' of github.com:cardano-found…
0c8ea8a 
…ation/cf-identity-wallet into feat/multisig-receive-acdc
@Sotatek-HocNguyena
refactor: remove id tag from identifierMetadata
d666472
@Sotatek-HocNguyena
Merge branch 'feat/create-multi-sig-oobi' of github.com:cardano-found…
dc12c10 
…ation/cf-identity-wallet into feat/multisig-receive-acdc
@Sotatek-HocNguyena
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
6d71b37 
…allet into feat/create-multi-sig-oobi
@Sotatek-HocNguyena
feat: add authorizedEids to multisig records
e0f5573
@Sotatek-HocNguyena
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
fc61379 
…allet into feat/create-multi-sig-oobi
@Sotatek-HocNguyena
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
349e959 
…allet into feat/multisig-receive-acdc
@Sotatek-HocNguyena
Merge branch 'feat/create-multi-sig-oobi' of github.com:cardano-found…
3924710 
…ation/cf-identity-wallet into feat/multisig-receive-acdc
@Sotatek-HocNguyena
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
5094e6c 
…allet into feat/multisig-receive-acdc
@Sotatek-HocNguyena
update: remove authorizedEids in identifier metadata
d05764a
@Sotatek-HocNguyena
revert: remove admitMultisig
a5faa20
@Sotatek-HocNguyena
refactor: mark the notification after join the authorization
c7fb6d7
@Sotatek-HocNguyena
feat: multisig receive acdc
7457aeb
@Sotatek-HocNguyena
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
9cfb5c8 
…allet into feat/multisig-receive-acdc
@Sotatek-BaoHoanga
Merge branch 'develop' into feat/multisig-receive-acdc
464b314
@Sotatek-BaoHoanga
Merge branch 'develop' into feat/multisig-receive-acdc
381554e
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-1id99vbq1.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-aarzfhj36.vercel.app

@Sotatek-BaoHoanga Sotatek-BaoHoanga marked this pull request as ready for review July 31, 2024 06:56
@Sotatek-BaoHoanga Sotatek-BaoHoanga self-assigned this Jul 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-g0p7e7ivb.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-7omnuclo0.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-8xq2ux9q7.vercel.app

iFergal
iFergal reviewed Aug 6, 2024
View reviewed changes
src/core/agent/services/multiSigService.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.ts Outdated Show resolved Hide resolved
src/core/agent/services/ipexCommunicationService.ts Show resolved Hide resolved
src/locales/en/en.json Outdated Show resolved Hide resolved
...pages/NotificationDetails/components/ReceiveCredentialMultisig/ReceiveCredentialMultisig.tsx Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.test.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.test.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.test.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.test.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-8ejjlto1j.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-c86rs21d3.vercel.app

@iFergal iFergal merged commit 6b023ed into develop Aug 7, 2024
1 check passed
@iFergal iFergal deleted the feat/multisig-receive-acdc branch August 7, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sotatek-BaoHoanga Sotatek-BaoHoanga Sotatek-BaoHoanga left review comments

@iFergal iFergal iFergal approved these changes

Assignees

@Sotatek-BaoHoanga Sotatek-BaoHoanga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sotatek-HocNguyena @iFergal @Sotatek-BaoHoanga