Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove prefix for credential ids #595

Merged
merged 43 commits into from
Aug 7, 2024
Merged

feat: remove prefix for credential ids #595

merged 43 commits into from
Aug 7, 2024

Conversation

Sotatek-TungNguyen2a
Copy link
Collaborator

Description

Remove the "metadata:" prefix for credential IDs

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

rcmorano and others added 22 commits April 3, 2023 17:17
@rcmorano
Release 0.1.0
a7e7ae3 
Merging develop to main 0.1.0
@cfuisat @iFergal
feat: Adding general PR template
9965ac9
@cfuisat @iFergal
fix: PR feedback applied
1361d86
@iFergal
Merge pull request #206 from cardano-foundation/docs/prTemplate
3287c5f 
docs: PR template on main
@iFergal
Merge pull request #281 from cardano-foundation/develop
68eaf0c 
Merge from develop into main
@iFergal
Merge pull request #283 from cardano-foundation/develop
f89d84e 
Merge from develop into main
@jorgenavben
docs: Update README.md
e9f1f95
@iFergal
Merge pull request #301 from cardano-foundation/develop
3164020 
Merge from develop to main
@iFergal
Merge pull request #308 from cardano-foundation/develop
f202258 
Merge from develop to main
@iFergal
Merge pull request #318 from cardano-foundation/develop
bc3a49d 
End of sprint merge
@iFergal
Merge pull request #336 from cardano-foundation/develop
e8c4c5a 
Merge from develop to main
@iFergal
Merge pull request #338 from cardano-foundation/develop
6009145 
Merge from develop to main (mediator URL fix)
@iFergal
Merge pull request #343 from cardano-foundation/develop
e4b975b 
Merge from develop to main
@iFergal
Merge pull request #368 from cardano-foundation/develop
c9079cc 
Merge from develop to main
@iFergal
Merge pull request #381 from cardano-foundation/develop
0e21751 
Merge from develop to main
@iFergal
Merge pull request #419 from cardano-foundation/develop
56f3a6a 
Merge from develop into main
@iFergal
Merge pull request #460 from cardano-foundation/develop
d32f6c5 
Merge from develop to main
@iFergal
Merge pull request #480 from cardano-foundation/develop
cc27b54 
Merge from develop to main
@iFergal
Merge pull request #525 from cardano-foundation/develop
cbf2ab7 
Merge from develop to main
@iFergal
Merge pull request #574 from cardano-foundation/develop
479888d 
Merge from develop to main
@iFergal
Merge pull request #577 from cardano-foundation/develop
5b3407d 
Merge from develop to main
@Sotatek-TungNguyen2a
feat: remove prefix for credential ids
4712860
@Sotatek-TungNguyen2a Sotatek-TungNguyen2a self-assigned this Jul 23, 2024
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-6cekt7se1.vercel.app

Sotatek-BaoHoanga and others added 3 commits July 25, 2024 10:51
@Sotatek-BaoHoanga
feat: add migration sql for old data
c1ea228
@Sotatek-TungNguyen2a
Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…
f7bae92 
…allet into feat/remove-prefix-for-credential-ids
@Sotatek-TungNguyen2a
Merge branch 'feat/remove-prefix-for-credential-ids' of github.com:ca…
1faae0e 
…rdano-foundation/cf-identity-wallet into feat/remove-prefix-for-credential-ids
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-ji3gxeith.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-2hm8zlsdw.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-dmz7mlzo5.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-m07x356wd.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-3uliepork.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-mn0oj4wzn.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-lu51c1ayq.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-ftswv8wr6.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-m4pee4wxn.vercel.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-9gsqj8zao.vercel.app

@iFergal
Copy link
Collaborator

iFergal commented Aug 6, 2024

testing this on physical device against develop, having some issues atm

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-mqm2fgai3.vercel.app

@iFergal iFergal merged commit cedb69c into develop Aug 7, 2024
1 check passed
@iFergal iFergal deleted the feat/remove-prefix-for-credential-ids branch August 7, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sotatek-BaoHoanga Sotatek-BaoHoanga Sotatek-BaoHoanga left review comments

@iFergal iFergal iFergal approved these changes

Assignees

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sotatek-TungNguyen2a @iFergal @Sotatek-BaoHoanga @rcmorano @cfuisat @jorgenavben