Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): New Credential Issuance for RareEvo #628

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Aug 2, 2024

Description

New Credential Issuance for RareEvo

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-1103

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Screenshot 2024-08-02 at 11 58 26

Android

Screenshot 2024-08-02 at 13 59 45

Browser

Screenshot 2024-08-02 at 11 14 58

Copy link

github-actions bot commented Aug 2, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-8mhm8tfo6.vercel.app

@sdisalvo-crd sdisalvo-crd merged commit bf788f6 into develop Aug 2, 2024
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-1103-rareevo-credential branch August 2, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants