Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Help center contacts missing #629

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

sdisalvo-crd
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd commented Aug 2, 2024

Description

Adding link to our Discord channel on the error page when a multi sig participant has forgotten to scan someone in their group.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-1092

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

02082024092532.mp4

Android

02082024092606.mp4

Browser

02082024091529.mp4

@sdisalvo-crd sdisalvo-crd self-assigned this Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-7jt069d90.vercel.app

@sdisalvo-crd sdisalvo-crd merged commit b4ed661 into develop Aug 2, 2024
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-1092-Help-Center-contacts-missing branch August 2, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants