Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): long running operations tests #630

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

Sotatek-TungNguyen2a
Copy link
Collaborator

Description

Add test coverage for the long running operations in the signify notification service

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Copy link

github-actions bot commented Aug 2, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-4n7wp5ged.vercel.app

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a changed the base branch from main to develop August 5, 2024 08:44
iFergal
iFergal previously approved these changes Aug 6, 2024
Copy link

github-actions bot commented Aug 7, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-17buq2exe.vercel.app

Copy link

github-actions bot commented Aug 7, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-4od425yft.vercel.app

@iFergal iFergal changed the title feat(core): long running operations tests test(core): long running operations tests Aug 7, 2024
@iFergal iFergal merged commit 8169c08 into develop Aug 7, 2024
1 check passed
@iFergal iFergal deleted the feat/long-running-operations-tests branch August 7, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants