Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): expose schema of a credential in short details #631

Merged

Conversation

Sotatek-TungNguyen2a
Copy link
Collaborator

Description

Expose schema of a credential in short details

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Copy link

github-actions bot commented Aug 5, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-fxd05gzhv.vercel.app

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a self-assigned this Aug 5, 2024
@Sotatek-TungNguyen2a Sotatek-TungNguyen2a changed the title feat(core): expose schema of a credential in short detials feat(core): expose schema of a credential in short details Aug 5, 2024
Copy link

github-actions bot commented Aug 6, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-2xbsr8cp1.vercel.app

@iFergal iFergal merged commit 7139342 into develop Aug 6, 2024
1 check passed
@iFergal iFergal deleted the feat/expose-schema-of-a-credential-in-short-details branch August 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants