Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nio to showcase #1370

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

openVietAnh
Copy link

👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

  1. Please complete a Checklist
  2. Fill in all sections of the template
  3. Click "Create pull request"

Checklist

<-- Please fill the boxes with [x] before submitting a pull request -->

Showcase addition

<-- Provide information for every bullet in the list below. The tags you select must match the tags in your changes to the showcase.js -->

  • Title: Nio
  • Description: Track all assets in wallets and locked in Cardano DeFi smart contracts. Effortlessly monitor your assets and whale wallets
  • Website: nioapp.io
  • Source:
  • Tags:
    • analytics
    • defi

@rphair rphair changed the title Add the Nio product to the showcase Add Nio to showcase Dec 4, 2024
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openVietAnh is there any documentation for this? Perhaps related: the GitHub icon at the bottom of the landing page is currently unlinked.

{
title: "Nio",
description:
"Track all assets in wallets and locked in Cardano DeFi smart contracts. Effortlessly monitor your assets and whale wallets",
Copy link
Collaborator

@rphair rphair Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Track all assets in wallets and locked in Cardano DeFi smart contracts. Effortlessly monitor your assets and whale wallets",
"Track and monitor all assets in any wallet or locked in Cardano DeFi smart contracts.",

We try to avoid promotional & subjective language in the Description: field (e.g. terms like "effortlessly" and "whale". Would you agree this revision is an impartial and complete description of your service?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the review, I have updated the description

src/data/showcases.js Outdated Show resolved Hide resolved
@rphair rphair added the showcase Indicates a PR/issue on showcase label Dec 4, 2024
@rphair
Copy link
Collaborator

rphair commented Dec 8, 2024

@openVietAnh if you want to create a valid submission you'll need to choose at least one of the valid tags in the showcases.js file (there is no defi tag).

@openVietAnh
Copy link
Author

@openVietAnh if you want to create a valid submission you'll need to choose at least one of the valid tags in the showcases.js file (there is no defi tag).

Thanks a lot for the feedback, I have updated the tag to 'explorer'

@rphair
Copy link
Collaborator

rphair commented Dec 11, 2024

@openVietAnh it doesn't fit with the current items having the explorer tag, which are all block explorers (as you can see when you hit the Block Explorer button in the Showcase): https://developers.cardano.org/showcase/?tags=explorer

@katomm I'm at a loss for a definitive choice about this. This tool resembles the stake key explorer on pool.pm which is listed in that category: though lacking the more general explorer features. Would it be fair to include it with the other explorers, or is there a better choice? (there seem only half-way matches: having some common ground with wallet, but without executing transactions, and analytics for specific but not general data structures)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Indicates a PR/issue on showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants