Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3152] Export of FineTypes to Haskell #13

Merged
merged 5 commits into from
Sep 19, 2023
Merged

[ADP-3152] Export of FineTypes to Haskell #13

merged 5 commits into from
Sep 19, 2023

Conversation

HeinrichApfelmus
Copy link
Collaborator

@HeinrichApfelmus HeinrichApfelmus commented Aug 31, 2023 •
edited
Loading

This pull requests implements the export of FineTypes Typ to Haskell types.

  • The command fine-types convert is able to export a FineTypes module to a Haskell module.
  • The types in the exported Haskell module are instances of a class ToValue a with member function toValue :: a -> Value.
  • A unit test covers the functionality by autogenerating a Haskell module from the file and using it in the fine-types-test package.

@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/export-haskell branch 4 times, most recently from 724d473 to cacf3fc Compare August 31, 2023 14:58
@HeinrichApfelmus HeinrichApfelmus self-assigned this Sep 1, 2023
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/export-haskell branch 2 times, most recently from d0854f8 to f54dde5 Compare September 6, 2023 10:21
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/export-haskell branch 6 times, most recently from 789a5c6 to 0ccdbe3 Compare September 18, 2023 10:19
@HeinrichApfelmus HeinrichApfelmus marked this pull request as ready for review September 18, 2023 13:01
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/export-haskell branch 2 times, most recently from 7c8b848 to aa52ef3 Compare September 19, 2023 10:37
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/export-haskell branch from aa52ef3 to 7f18063 Compare September 19, 2023 11:25
paolino
paolino approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@paolino paolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great milestone :-)

@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Sep 19, 2023
@HeinrichApfelmus
Copy link
Collaborator Author

Thanks! 😊

Merged via the queue into main with commit a8a946e Sep 19, 2023
15 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the HeinrichApfelmus/export-haskell branch September 19, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolino paolino paolino approved these changes

Assignees

@HeinrichApfelmus HeinrichApfelmus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeinrichApfelmus @paolino