Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3138] Add random generators for Typ #5

Merged
merged 3 commits into from
Aug 24, 2023
Merged

[ADP-3138] Add random generators for Typ #5

merged 3 commits into from
Aug 24, 2023

Conversation

paolino
Copy link
Contributor

@paolino paolino commented Aug 23, 2023 •
edited
Loading

  • Add QC generation for Typ values
  • Use precedence numbers for fourmolu as found in base lib

ADP-3138

@paolino paolino self-assigned this Aug 23, 2023
@paolino paolino changed the base branch from paolino/ADP-3135/add-generators-for-value-type to HeinrichApfelmus/init August 23, 2023 13:31
@paolino paolino force-pushed the paolino/ADP-3138/add-generators-for-typ-type branch from 268ff4c to 47632ed Compare August 23, 2023 13:37
@paolino paolino force-pushed the paolino/ADP-3138/add-generators-for-typ-type branch from 47632ed to 2e1446b Compare August 23, 2023 14:24
Base automatically changed from HeinrichApfelmus/init to main August 23, 2023 14:26
@HeinrichApfelmus HeinrichApfelmus changed the title [ADP-3138] add generators for typ type [ADP-3138] Add random generators for Typ Aug 23, 2023
HeinrichApfelmus
HeinrichApfelmus approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@HeinrichApfelmus HeinrichApfelmus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 😊 Could you backport the fix for logScale, and slightly rewrite shaping?

I would prefer DepthGen to be a type synonym, but I leave that up to you.

fourmolu.yaml Outdated Show resolved Hide resolved
fourmolu.yaml Outdated Show resolved Hide resolved
lib/fine-types/src/Language/FineTypes/Typ/Gen.hs Outdated Show resolved Hide resolved
lib/fine-types/src/Language/FineTypes/Typ/Gen.hs Outdated Show resolved Hide resolved
lib/fine-types/src/Language/FineTypes/Typ/Gen.hs Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3138/add-generators-for-typ-type branch from 9117a2a to b26ebaf Compare August 24, 2023 12:36
@paolino paolino added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 40d36e8 Aug 24, 2023
15 checks passed
@paolino paolino deleted the paolino/ADP-3138/add-generators-for-typ-type branch August 24, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus