Run CI on PHP83 and merge PHPStan configurations

.github/workflows/integrate.yaml

@@ -20,10 +20,7 @@ jobs:
  strategy:
  matrix:
  php-version:
- - "7.4"
- - "8.0"
- - "8.1"
- - "8.2"
+ - "8.3"
  dependencies:
  - "highest"
  steps:
@@ -52,44 +49,8 @@ jobs:
  - name: "Run friendsofphp/php-cs-fixer"
  run: "vendor/bin/php-cs-fixer check --config ./ci/php-cs-fixer.php"
 
- architecture-analysis:
- name: "Architecture analysis"
- runs-on: "ubuntu-latest"
- strategy:
- matrix:
- php-version:
- - "7.4"
- - "8.0"
- - "8.1"
- - "8.2"
- dependencies:
- - "highest"
- steps:
- - name: "Checkout"
- uses: "actions/checkout@v2"
- - name: "Install PHP with extensions"
- uses: "shivammathur/setup-php@v2"
- with:
- coverage: "none"
- extensions: "${{ env.PHP_EXTENSIONS }}"
- php-version: "${{ matrix.php-version }}"
- - name: "Determine composer cache directory"
- uses: "./.github/actions/composer/composer/determine-cache-directory"
- - name: "Cache dependencies installed with composer"
- uses: "actions/cache@v2"
- with:
- path: "${{ env.COMPOSER_CACHE_DIR }}"
- key: "php-${{ matrix.php-version }}-composer-${{ matrix.dependencies }}-${{ hashFiles('composer.lock') }}"
- restore-keys: "php-${{ matrix.php-version }}-composer-${{ matrix.dependencies }}-"
- - name: "Install ${{ matrix.dependencies }} dependencies with composer"
- uses: "./.github/actions/composer/composer/install"
- with:
- dependencies: "${{ matrix.dependencies }}"
- - name: "Run phpstan+phpat for architecture tests"
- run: "vendor/bin/phpstan analyse -c ci/phpstan-phpat.neon"
-
  static-code-analysis:
- name: "Static Code Analysis"
+ name: "Static Code and Architecture analysis"
  runs-on: "ubuntu-latest"
  strategy:
  matrix:
@@ -98,6 +59,7 @@ jobs:
  - "8.0"
  - "8.1"
  - "8.2"
+ - "8.3"
  dependencies:
  - "highest"
  steps:
@@ -121,9 +83,9 @@ jobs:
  uses: "./.github/actions/composer/composer/install"
  with:
  dependencies: "${{ matrix.dependencies }}"
- - name: "Run phpstan/phpstan"
- run: "vendor/bin/phpstan analyse -c ci/phpstan.neon"
- - name: "Run vimeo/psalm"
+ - name: "Run phpstan+phpat"
+ run: "vendor/bin/phpstan analyse -c ci/phpstan-phpat.neon"
+ - name: "Run psalm"
  run: "vendor/bin/psalm -c ci/psalm.xml"
 
  tests:
@@ -136,6 +98,7 @@ jobs:
  - "8.0"
  - "8.1"
  - "8.2"
+ - "8.3"
  dependencies:
  - "highest"
  steps:

ci/phpstan-phpat.neon

@@ -2,10 +2,15 @@ includes:
  - ../extension.neon
 
 parameters:
- level: 0
+ level: 8
  paths:
  - ../src
+ - ../tests/unit/rules
  - ../tests/architecture
+ ignoreErrors:
+ -
+ message: "#no value type specified in iterable type array\\.$#"
+ path: *
  phpat:
  ignore_built_in_classes: false
  show_rule_names: true

docs/contributing.md

@@ -19,7 +19,6 @@ There are several ways to help out:
 ```bash
 composer validate --strict
 vendor/bin/php-cs-fixer fix --config ./ci/php-cs-fixer.php
-vendor/bin/phpstan analyse -c ci/phpstan.neon
 vendor/bin/phpstan analyse -c ci/phpstan-phpat.neon
 vendor/bin/psalm -c ci/psalm.xml
 vendor/bin/phpunit tests/unit/