Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IsTrait and IsNotTrait selectors #283

Merged
merged 5 commits into from
Sep 29, 2024
Merged

add IsTrait and IsNotTrait selectors #283

merged 5 commits into from
Sep 29, 2024

Conversation

ghostwriter
Copy link
Contributor

This patch adds IsTrait and IsNotTrait selectors.

@ghostwriter
Update IsNotFinal.php
46fe9d9 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Add IsNotTrait.php
ddb843f 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Add IsTrait.php
53ba284 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update SelectorPrimitive.php
9724b63 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
carlosas
carlosas requested changes Sep 1, 2024
View reviewed changes
Copy link
Owner

@carlosas carlosas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please update the documentation as well :)

@ghostwriter
Update selectors.md
a541574 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@carlosas
Copy link
Owner

carlosas commented Sep 29, 2024 •
edited
Loading

I'll merge but I'll remove Selector::isNotTrait() since it can be accomplished with Selector::NOT(Selector::isTrait())

@carlosas carlosas merged commit 737c6de into carlosas:master Sep 29, 2024
11 checks passed
@ghostwriter ghostwriter deleted the oss/feature/is-trait-selector branch September 29, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosas carlosas carlosas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostwriter @carlosas