Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IsException, IsError, and IsThrowable selectors #288

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add IsException, IsError, and IsThrowable selectors #288

wants to merge 5 commits into from

Conversation

ghostwriter
Copy link

@ghostwriter ghostwriter commented Aug 25, 2024 •
edited
Loading

This patch adds IsException, IsError, and IsThrowable selectors.

@ghostwriter ghostwriter changed the title add IsException selector modifier add IsException selector Aug 25, 2024
carlosas
carlosas requested changes Sep 1, 2024
View reviewed changes
Copy link
Owner

@carlosas carlosas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Besides the comment in the code, the new selector should be added to the Selectors section in the docs.

src/Selector/IsException.php Outdated Show resolved Hide resolved
@ghostwriter
Update selectors.md
0fb6bc2 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Add IsError.php
86bf1c8 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Add IsException.php
c2dc9c4 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Add IsThrowable.php
52648d2 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update SelectorPrimitive.php
58f0739 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter changed the title add IsException selector add IsException, IsError, and IsThrowable selectors Sep 1, 2024
@ghostwriter ghostwriter changed the title add IsException, IsError, and IsThrowable selectors add IsException, IsError, and IsThrowable selectors Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosas carlosas Awaiting requested review from carlosas

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostwriter @carlosas