-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored Office 365 Plugin #1225
base: master
Are you sure you want to change the base?
Conversation
3137829
to
f6c7dde
Compare
Thank you! I tried on my Raspberry pi running klipper and got:
User error on my end? |
Indeed there was a user error on my end, I copied and pasted the o365:// link in the old format. Once corrected, still get same error, unfortunately.
Edit - same error if secret is url-encoded or not Edit2: Adding --debug gives:
On checking, I see all lib/python/ directories are there except the final /en |
Unfortunately this PR is still in development. It may not work because i don't have an Azure connection to test with anymore. Would you actually be able to assist and create an email for me to develop with? You can delete it right after? If this is not something you can help with, I understand. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1225 +/- ##
==========================================
- Coverage 99.37% 99.30% -0.07%
==========================================
Files 148 147 -1
Lines 20675 20608 -67
Branches 3679 3678 -1
==========================================
- Hits 20545 20465 -80
- Misses 121 131 +10
- Partials 9 12 +3 ☔ View full report in Codecov by Sentry. |
I just tested and get different errors now:
|
I still have a ways to go on my end. I just wanted to push up the code that i had on my local PC. This is a bit of a learning curve for me. Sorry for the wait; please be patient |
Description:
Related issue (if applicable): #1217, #836, and #858
Refactoring Office 365 Plugin and updating wiki page
Checklist
flake8
)Testing
Anyone can help test this source code as follows: