add junit 3 test (disabled)

sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/AbstractTool.java

@@ -967,12 +967,12 @@ protected boolean isLifecycleMethod(MethodDeclaration method, String methodName)
 	    return methodName.equals(method.getName().getIdentifier());
 	}
 
-	private boolean isStringType(Expression expression, Class<String> classType) {
+	protected boolean isStringType(Expression expression, Class<String> classType) {
 	    ITypeBinding typeBinding = expression.resolveTypeBinding();
 	    return typeBinding != null && classType.getCanonicalName().equals(typeBinding.getQualifiedName());
 	}
 
-	private boolean isSubtypeOf(ITypeBinding subtype, ITypeBinding supertype) {
+	protected boolean isSubtypeOf(ITypeBinding subtype, ITypeBinding supertype) {
 	    return subtype != null 
 	           && supertype != null 
 	           && (isTypeOrSubtype(subtype, supertype.getQualifiedName()) || implementsInterface(subtype, supertype));
@@ -1262,8 +1262,6 @@ public void reorderParameters(MethodInvocation node, ASTRewrite rewriter, TextEd
 		}
 	}
 
-
-
 	private void replaceFieldWithExtensionDeclaration(ClassInstanceCreation classInstanceCreation,
 			String nestedClassName, boolean fieldStatic, ASTRewrite rewriter, AST ast, TextEditGroup group,
 			ImportRewrite importRewriter) {

sandbox_junit_cleanup_test/src/org/eclipse/jdt/ui/tests/quickfix/Java8/JUnit3CleanupCases.java

@@ -0,0 +1,173 @@
+package org.eclipse.jdt.ui.tests.quickfix.Java8;
+
+/*-
+ * #%L
+ * Sandbox junit cleanup test
+ * %%
+ * Copyright (C) 2024 hammer
+ * %%
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0.
+ * 
+ * This Source Code may also be made available under the following Secondary
+ * Licenses when the conditions for such availability set forth in the Eclipse
+ * Public License, v. 2.0 are satisfied: GNU General Public License, version 2
+ * with the GNU Classpath Exception which is
+ * available at https://www.gnu.org/software/classpath/license.html.
+ * 
+ * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+ * #L%
+ */
+
+enum JUnit3CleanupCases{
+		Junit3Case(
+				"""
+package test;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+public class MyTest extends TestCase {
+
+    public MyTest(String name) {
+        super(name);
+    }
+
+    @Override
+    protected void setUp() throws Exception {
+        // Setup vor jedem Test
+    }
+
+    @Override
+    protected void tearDown() throws Exception {
+        // Aufräumen nach jedem Test
+    }
+
+    public static Test suite() {
+        TestSuite suite = new TestSuite();
+        suite.addTest(new MyTest("testBasicAssertions"));
+        suite.addTest(new MyTest("testArrayAssertions"));
+        suite.addTest(new MyTest("testWithAssume"));
+        suite.addTest(new MyTest("testAssertThat"));
+        suite.addTest(new MyTest("testEqualityWithDelta"));
+        suite.addTest(new MyTest("testFail"));
+        return suite;
+    }
+
+    public void testBasicAssertions() {
+        assertEquals("Values should match", 42, 42);
+        assertTrue("Condition should be true", true);
+        assertFalse("Condition should be false", false);
+        assertNull("Should be null", null);
+        assertNotNull("Should not be null", new Object());
+    }
+
+    public void testArrayAssertions() {
+        int[] expected = {1, 2, 3};
+        int[] actual = {1, 2, 3};
+        assertEquals("Arrays should match", expected.length, actual.length);
+        for (int i = 0; i < expected.length; i++) {
+            assertEquals("Array element mismatch at index " + i, expected[i], actual[i]);
+        }
+    }
+
+    public void testWithAssume() {
+        assumeTrue("Precondition failed", true);
+        assumeFalse("Precondition not met", false);
+    }
+
+    public void testAssertThat() {
+        assertEquals("Value should match", 42, 42); // Ersatz für assertThat in JUnit 3
+    }
+
+    public void testEqualityWithDelta() {
+        assertEquals("Floating point equality with delta", 0.1 + 0.2, 0.3, 0.0001);
+    }
+
+    public void testFail() {
+        fail("This test should fail with a message.");
+    }
+}
+
+				"""
+				,
+				"""
+package test;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.jupiter.api.Assumptions.*;
+
+import org.junit.jupiter.api.*;
+
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
+public class MyTest {
+
+    @BeforeEach
+    public void setUp() throws Exception {
+        // Setup vor jedem Test
+    }
+
+    @AfterEach
+    public void tearDown() throws Exception {
+        // Aufräumen nach jedem Test
+    }
+
+    @Test
+    @Order(1)
+    public void testBasicAssertions() {
+        assertEquals(42, 42, "Values should match");
+        assertTrue(true, "Condition should be true");
+        assertFalse(false, "Condition should be false");
+        assertNull(null, "Should be null");
+        assertNotNull(new Object(), "Should not be null");
+    }
+
+    @Test
+    @Order(2)
+    public void testArrayAssertions() {
+        int[] expected = {1, 2, 3};
+        int[] actual = {1, 2, 3};
+        assertArrayEquals(expected, actual, "Arrays should match");
+    }
+
+    @Test
+    @Order(3)
+    public void testWithAssume() {
+        assumeTrue(true, "Precondition failed");
+        assumeFalse(false, "Precondition not met");
+    }
+
+    @Test
+    @Order(4)
+    public void testAssertThat() {
+        assertThat("Value should match", 42, is(42));
+    }
+
+    @Test
+    @Order(5)
+    public void testEqualityWithDelta() {
+        assertEquals(0.3, 0.1 + 0.2, 0.0001, "Floating point equality with delta");
+    }
+
+    @Test
+    @Order(6)
+    public void testFail() {
+        fail("This test should fail with a message.");
+    }
+}
+
+				"""
+				); //$NON-NLS-1$
+
+		String given;
+		String expected;
+
+		JUnit3CleanupCases(String given, String expected) {
+			this.given=given;
+			this.expected=expected;
+		}
+	}

sandbox_junit_cleanup_test/src/org/eclipse/jdt/ui/tests/quickfix/Java8/JUnitMigrationCleanUpTest.java

@@ -39,6 +39,7 @@
 import org.eclipse.jdt.core.IPackageFragmentRoot;
 import org.eclipse.jdt.junit.JUnitCore;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -87,6 +88,30 @@
 		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_RUNWITH);
 		context4junit4.assertRefactoringResultAsExpected(new ICompilationUnit[] {cu}, new String[] {test.expected}, null);
 	}
+
+	@Disabled
+	@ParameterizedTest
+	@EnumSource(JUnit3CleanupCases.class)
+	public void testJUnit3CleanupParametrized(JUnit3CleanupCases test) throws CoreException {
+		IPackageFragment pack= fRootJUnit4.createPackageFragment("test", true, null);
+		ICompilationUnit cu= pack.createCompilationUnit("MyTest.java", test.given, true, null); //$NON-NLS-1$
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_ASSERT);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_ASSUME);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_SUITE);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_BEFORE);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_AFTER);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_BEFORECLASS);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_AFTERCLASS);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_IGNORE);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_TEST);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_RULETEMPORARYFOLDER);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_RULETESTNAME);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_RULEEXTERNALRESOURCE);
+//		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_EXTERNALRESOURCE);
+		context4junit4.enable(MYCleanUpConstants.JUNIT_CLEANUP_4_RUNWITH);
+		context4junit4.assertRefactoringResultAsExpected(new ICompilationUnit[] {cu}, new String[] {test.expected}, null);
+	}
 
 	enum NOJUnitCleanupCases {