-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpha: Rollups v2 support #52
Open
brunomenezes
wants to merge
11
commits into
main
Choose a base branch
from
alpha/rollups-v2-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomenezes
requested review from
tuler and
nevendyulgerov
and removed request for
tuler and
nevendyulgerov
November 14, 2024 01:06
Hey @tuler, could you confirm my bullet point 3 about the |
brunomenezes
force-pushed
the
alpha/rollups-v2-support
branch
from
November 15, 2024 03:03
98000e3
to
f04be0e
Compare
…d v2 apps. Also, exclude non-usual-apps (i.e. created by input-added evts).
…nclude v2 apps for ownership-transferred logs.
brunomenezes
force-pushed
the
alpha/rollups-v2-support
branch
from
December 9, 2024 03:55
f04be0e
to
cd50c6d
Compare
brunomenezes
added
the
Status: On-Hold
On-hold for further development, because upcoming changes will affect the Issue or PR targeted
label
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: On-Hold
On-hold for further development, because upcoming changes will affect the Issue or PR targeted
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code changes to support both rollup contracts v1 and v2 (currently available only for devnet and Sepolia).
Changes:
Application
model to be queryable based on rollups version without the need to check the factory address (Depending on the query, it means no join).ApplicationCreated
andInputAdded
events.OwnershipTransferred
was updated to deal with both v1 and v2 events instead of adding a new one, as the topic hash for both contracts is the same. After looking at the generated code from ABI, I believe both handlers would be called sequentially, deeming a new handler unnecessary. PS: I assume it will be picked as the topic matches. There are at least three apps created on Sepolia, but none emitted the event.Events