-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support load policy from text #372
Conversation
@sagilio please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is not suitable to provide multiple modes in the FileAdapter, but rather to provide different Adapters.
You can try to use the existing FileAdapter as a base class and extend it to create File, Stream, and Text three types of Adapters.
Signed-off-by: Taoyuesong <tao634774653@gmail.com>
Signed-off-by: Taoyuesong <tao634774653@gmail.com>
Signed-off-by: Taoyuesong <tao634774653@gmail.com>
Signed-off-by: Taoyuesong <tao634774653@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 2.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
close #371
This issue will be add new Text Adapter.