Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify casbin version handling with environment variables #173

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

HashCookie
Copy link
Contributor

@HashCookie HashCookie commented Dec 13, 2024

Description

This PR simplifies the way of handling Casbin versions in the editor:

  • Removing the webpack plugin approach that generates a JSON file
  • Using Next.js environment variables to inject the version at build time
  • Cleaning up related files and code

Benefits

  • Simpler code structure
  • No extra network requests
  • No file I/O during build

Testing

  • Casbin version still displays correctly
  • Build process works without errors

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for casbin-editor ready!

Name Link
🔨 Latest commit b6f4710
🔍 Latest deploy log https://app.netlify.com/sites/casbin-editor/deploys/675bcb1eb5b2ce0008cb4bc8
😎 Deploy Preview https://deploy-preview-173--casbin-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hsluoyz hsluoyz merged commit feab870 into casbin:master Dec 13, 2024
9 checks passed
@hsluoyz
Copy link
Member

hsluoyz commented Dec 14, 2024

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants