feat: improve performance of AddPolicies #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ishikawa-pro
force-pushed
the
improve-add-policies
branch
from
3d018a3 to
97fd7cf
Compare
hsluoyz
changed the title
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Improve Performance of AddPolicies in MongoDB Adapter
Description:
This Pull Request aims to enhance the performance of the
AddPoliciesfunction in the Casbin MongoDB adapter. The current implementation ofAddPoliciesinserts each policy rule using the InsertOne method.However, inserting multiple lines in a single operation is more efficient. Therefore, this update refactors
AddPoliciesto utilizeInsertMany, significantly reducing the number of database operations and potentially improving overall performance for adding multiple policies.Changes:
linesslice to a slice ofinterface{}to accommodate the requirements of theInsertManymethod.InsertOnemethod withInsertManyfor inserting multiple policy lines in a single database call.