Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace legacy sendAsync with request #373

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

chaitanyapotti
Copy link
Contributor

@chaitanyapotti chaitanyapotti commented Oct 10, 2023

Most providers now support request method and send, sendAsync are now considered deprecated

@chaitanyapotti
Copy link
Contributor Author

Most multi-chain providers now follow EIP-1193 spec (https://eips.ethereum.org/EIPS/eip-1193#specification)

Copy link
Contributor

@hoffmannjan hoffmannjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MParlikar
Copy link

bors r+

@rob-casper
Copy link
Contributor

force merge while waiting for 1.5.3 casper-node tag (impacting CI build job) as per discussions with @gyroflaw & @hoffmannjan

@rob-casper rob-casper merged commit 7db9a50 into casper-ecosystem:dev Oct 17, 2023
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants