Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACL package mode (mint) + package operator mode (transfer/approve/revoke) #249

Merged
merged 21 commits into from
Oct 3, 2023

Conversation

gRoussac
Copy link
Contributor

@gRoussac gRoussac commented Sep 22, 2023

… into issue-215

# Conflicts:
#	contract/src/main.rs
#	tests/src/set_variables.rs
@gRoussac gRoussac marked this pull request as ready for review September 22, 2023 11:38
@gRoussac gRoussac requested a review from deuszex September 22, 2023 11:38
@gRoussac gRoussac added the enhancement New feature or request label Sep 22, 2023
@gRoussac gRoussac requested a review from bpr September 22, 2023 11:39
@@ -34,6 +34,7 @@ setup-test: build-contract
mkdir -p tests/wasm/1_1_0; curl -L https://github.com/casper-ecosystem/cep-78-enhanced-nft/releases/download/v1.1.0/cep-78-wasm.tar.gz | tar zxv -C tests/wasm/1_1_0/
mkdir -p tests/wasm/1_2_0; curl -L https://github.com/casper-ecosystem/cep-78-enhanced-nft/releases/download/v1.2.0/cep-78-wasm.tar.gz | tar zxv -C tests/wasm/1_2_0/
mkdir -p tests/wasm/1_3_0; curl -L https://github.com/casper-ecosystem/cep-78-enhanced-nft/releases/download/v1.3.0/cep-78-wasm.tar.gz | tar zxv -C tests/wasm/1_3_0/
mkdir -p tests/wasm/1_4_0; curl -L https://github.com/casper-ecosystem/cep-78-enhanced-nft/releases/download/v1.4.0/cep-78-wasm.tar.gz | tar zxv -C tests/wasm/1_4_0/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is becoming a bit odd to download every version

Copy link
Contributor

@ACStone-MTS ACStone-MTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small wording changes for documentation.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/modalities.md Outdated Show resolved Hide resolved
docs/modalities.md Outdated Show resolved Hide resolved
docs/modalities.md Outdated Show resolved Hide resolved
docs/modalities.md Outdated Show resolved Hide resolved
docs/modalities.md Outdated Show resolved Hide resolved
gRoussac and others added 16 commits September 22, 2023 17:06
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
Co-authored-by: Adam Stone <97986246+ACStoneCL@users.noreply.github.com>
tests/src/acl.rs Outdated Show resolved Hide resolved
@gRoussac gRoussac merged commit b08ff4e into casper-ecosystem:dev Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Transfer approval for contracts should (probably) be based on the contract package hash
3 participants