[Test] contract staking test contract #4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct-staking-test-contract
EdHastingsCasperAssociation
requested review from
zajko and
darthsiroftardis
| if let Some(StoredValue::Unbonding(unbonding_purses)) = | ||
| tc.get(&key).map_err(Into::<ProtocolUpgradeError>::into)? | ||
| { | ||
| // prune away the original record, we don't need it anymore |
There was a problem hiding this comment.
Should we have an if condition to only migrate unbonding purses based on the unbonding delay, i.e what we did for redelegate, only migrate the purses that are yet to be paid
There was a problem hiding this comment.
Maybe. However, the original logic was a stored value of a vec of unbonding purses which were being popped off for a pseudo prune so there shouldn't be any such records.
On that note tho, an optimization to not write the record if unbond.eras().len() == 0 would certainly be feasible.
darthsiroftardis
approved these changes
Nov 25, 2024
|
bors r+ |
| @@ -479,6 +479,11 @@ where | |||
| &self.runtime_footprint | |||
| } | |||
|
|
|||
| /// Returns the addressable entity being used by this instance. | |||
There was a problem hiding this comment.
Just noticed this docu comment is wrong. Should be:
"Returns a mutable reference to the runtime footprint used by this instance."
|
Build succeeded: |
casperlabs-bors-ng
bot
merged commit 2bdfb49
into
casper-network:feat-2.0
3 checks passed
|
Related issue #4929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test contract for contract staking to prevent regression.