fix: use /sec:tls in all RDP commands. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, if you use xfreerdp without it, the application will just raise error ERRCONNECT_LOGON_FAILURE, and according to FreeRDP/FreeRDP#5972#issuecomment-674729392, we need to disable Allow connections only from computers running Remote Desktop with Network Level Authentication (recommended) and use /sec:tls for the connection to work. This commit add /sec:tls to all RDP commands.
|
Another thing worth mentioning is that if you merge this PR, you should update the instruction for Windows VM and tell users to disable |
|
Why was this PR not merged is there any issue with it @casualsnek ? |
I bet that this project is dead, it was last updated 2 years ago 💀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if you use xfreerdp without the argument, the application will just raise error
ERRCONNECT_LOGON_FAILURE, and according to FreeRDP/FreeRDP#5972 (specifically this comment), we need to disableAllow connections only from computers running Remote Desktop with Network Level Authentication (recommended)in Windows (where we have cassowary server) and use/sec:tlsfor the connection to work. This commit adds/sec:tlsto all RDP commands.