Fix warnings about not checking return value.

catalogicsoftware · Jan 23, 2020 · c4accf4 · c4accf4
1 parent 4819102
commit c4accf4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/kubedr/config/manager/kustomization.yaml b/kubedr/config/manager/kustomization.yaml
@@ -5,4 +5,4 @@ kind: Kustomization
 images:
 - name: controller
   newName: kubedr
-  newTag: latest
+  newTag: "0.53"
diff --git a/kubedr/controllers/backuplocation_controller.go b/kubedr/controllers/backuplocation_controller.go
@@ -72,7 +72,7 @@ func ignoreErrors(err error) error {
 	return err
 }
 
-func (r *BackupLocationReconciler) setStatus(backupLoc *kubedrv1alpha1.BackupLocation, status string, errmsg string) error {
+func (r *BackupLocationReconciler) setStatus(backupLoc *kubedrv1alpha1.BackupLocation, status string, errmsg string) {
 	backupLoc.Status.InitStatus = status
 	if errmsg == "" {
 		// For some reason, empty error string is causing problems even though
@@ -86,10 +86,7 @@ func (r *BackupLocationReconciler) setStatus(backupLoc *kubedrv1alpha1.BackupLoc
 	r.Log.Info("Updating status...")
 	if err := r.Status().Update(context.Background(), backupLoc); err != nil {
 		r.Log.Error(err, "unable to update backup location status")
-		return err
 	}
-
-	return nil
 }
 
 func (r *BackupLocationReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {