Conversion test #102
Draft
Conversion test #102
+364
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…to conversion_test
for more information, see https://pre-commit.ci
h-mayorquin
reviewed
Dec 13, 2024
| @@ -27,3 +29,12 @@ def get_metadata(self) -> dict: | |||
| ) | |||
|
|
|||
| return metadata | |||
|
|
|||
| def __init__( | |||
There was a problem hiding this comment.
@grg2rsr this will fix the issue that we discussed on Wednesday.
|
The current error in the CI is because of this line: def __init__(self, one: ONE, session: str, revision: str | None = None):The thing is that python only supports the typing |
…to conversion_test
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… into conversion_test
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including:
read after write conversion checks
revisions being explicitly passed to the data interfaces