Move session start time to the NWBExtractor #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
h-mayorquin
commented
Nov 30, 2023
| series_datetime = read_session_date_from_file(folder_path=self.folder_path) | ||
| return series_datetime | ||
| relative_times = [ | ||
| float(frame.attrib["relativeTime"]) for frame in frame_elements |
There was a problem hiding this comment.
Changing this to relativeTime as in the comment.
h-mayorquin
commented
Nov 30, 2023
| description=f"{self.imaging_purpose} imaging data ({indicator}) acquired from the Bruker Two-Photon Microscope", | ||
| unit="px", | ||
| description=f"{self.imaging_purpose} imaging data ({indicator})", | ||
| unit="voxels", |
There was a problem hiding this comment.
I am not sure about this @alessandratrapani what do you think?
There was a problem hiding this comment.
Actually it should be n.a. as in the default value. My mistake, I misunderstood the meaning here. For reference see this discussion
There was a problem hiding this comment.
OK, changed, thanks!
alessandratrapani
approved these changes
Nov 30, 2023
h-mayorquin
commented
Nov 30, 2023
h-mayorquin
commented
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the methods to extract the session start time from the extractor to the interface where it belongs.