Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick's pull request for a version that works on openmind #13

Merged
merged 11 commits into from
Dec 19, 2023
Merged

Conversation

nwatters01
Copy link
Collaborator

Summary of changes:

  • Some cosmetic changes (variables names, formatting, updating README, etc.).
  • Added display_interface.py. This introduces a new data table representing display updates. Each display update comes with several variables (timestamp, object positions, fixation cross size, task phase and closed-loop gaze position). These are put into a TimeIntervalsInterface as a dataframe.
  • Added get_session_paths.py. This factors out a function to get all the paths to the different components of the data, for either openmind (our cluster) or globus. This function is passed a _REPO flag from the main run script, which can be either 'openmind' or 'globus' to reflect the two filesystems.
  • Added timeseries_interfaces.py. This introduces two interfaces, the AudioInterface and the RewardInterface, that add audio and reward datastreams to the nwb file.

Also, apologies for somehow the filename changes not being tracked by git. Despite now several times re-trying to get git to track filename changes (using git mv to rename, deleting and re-branching, forking, etc.), I have no idea why some of the filename changes aren't being tracked.

This code all works great on openmind (with the potential exception of automatic uploading, but I'll try that soon). Specific things I'd love to get your input on:

  • Are the interfaces in display_interface.py and timeseries_interfaces.py reasonable?

@CodyCBakerPhD
Copy link
Member

@nwatters01 I resolved all the conflicts from this branch - can you double check for me and see if everything works as expected? If so, go ahead and merge since it all looks good to me

@nwatters01
Copy link
Collaborator Author

Everything works as expected on openmind, thanks for your help!

I'm going ahead and merging

@nwatters01 nwatters01 merged commit 3b8fbe0 into main Dec 19, 2023
1 check passed
@nwatters01 nwatters01 deleted the nwatters branch December 19, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants