Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary rename to avoid collision #14

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Temporary rename to avoid collision #14

merged 1 commit into from
Jun 26, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Smaller workaround to the more generic and extension fix of #12 to avoid a name collision when using both ndx_microscopy and ndx_patterened_ogen

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jun 24, 2024
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge June 24, 2024 19:12
@CodyCBakerPhD
Copy link
Member Author

@alessandratrapani This is just a quick smaller version of your main PR so I can get this up and running with a conversion

@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Jun 26, 2024
Merged
@CodyCBakerPhD CodyCBakerPhD requested a review from rly June 26, 2024 20:53
rly
rly approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@rly rly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Should the README diagram also be updated?

@CodyCBakerPhD CodyCBakerPhD merged commit 5d6129c into main Jun 26, 2024
34 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the avoid_name_collision branch June 26, 2024 21:36
@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rly rly rly approved these changes

@alessandratrapani alessandratrapani Awaiting requested review from alessandratrapani

Assignees

@CodyCBakerPhD CodyCBakerPhD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodyCBakerPhD @rly