[Enhancement III] Swap to um for depth #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Enhacement II] Testing
…able_depth_static
…able_depth_static
CodyCBakerPhD
changed the title
…github.com/catalystneuro/ndx-microscopy into all_previous_prs_and_variable_depth_static
for more information, see https://pre-commit.ci
…github.com/catalystneuro/ndx-microscopy into all_previous_prs_and_variable_depth_static
for more information, see https://pre-commit.ci
Base automatically changed from
all_previous_prs_and_variable_depth_static
to
main
July 19, 2024 14:00
for more information, see https://pre-commit.ci
|
@alessandratrapani Small adjustment to units for variable depth field |
alessandratrapani
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a reminder that the long term plan is to separate these variable depth types into a separate extension that depends on this one; it's just easier to develop/debug with them all in the same place at the moment
Swapping from units
mmtoumsince that seems to be a more standard unit of measure for depth