Change wavelengths definition and add optical filter device #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peak wavelength issue
peak_wavelength
for thephotodetector
can be confusing: does it mean the peak of the responsivity curve of the photodetector or the wavelength of interest (the one that is usually reported in the papers and filtered with an optical filter before hitting the detector)? I would store the actual detected wavelength and call the field:detected_wavelength
peak_wavelength
forexcitation_sources
it's fine, but I would change toexcitation_wavelength
for simplicity.finally, the
emission_peak_wavelength
and theexcitation_peak_wavelength
of the fluorophore are characteristics of the protein’s spectrum in a specific configuration, e.g. GCaMP6 bound to Ca2+ or independent from Ca2+.The important information for these experiments to be reproduced are:
TODOs for this PR:
peak_wavelength
for thephotodetector
todetected_wavelength
peak_wavelength
for theexcitation_sources
toexcitation_wavelength
emission_peak_wavelength
and theexcitation_peak_wavelength
of thefluorophore
(to avoid confusion)OpticalFilter
(Device) (this could be designed to match the same device for ndx-microscopy (link to Make filter (on OpticalChannel and LightSource) an optional Device ndx-microscopy#6). It should be described byOpticalFilter
in bothphotodetector
andexcitation_sources
as an extra columnDichroicMirror
in thefibers_table