Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest version of ndx pose for DeepLabCutInterface #1128

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Collaborator

This uses the latest release of ndx-pose and modifies the DeepLabCutInterface class to use the latest API (e.g. Skeletons instead of nodes).

This is related to both:
#1114
and
#1127

@pauladkisson
Copy link
Member

@h-mayorquin, are there any blockers on this? Having this done will help me ensure that the dev tests are fixed properly.

@h-mayorquin
Copy link
Collaborator Author

h-mayorquin commented Dec 13, 2024

We are waiting for sleap.io to review the PR:

talmolab/sleap-io#143

If having this would make your life easier I propose

  • You can update LightningPose and upgrade it.
  • Then I can modify the CI so we test sleap interface as a stand-alone test while the PR above gets merged.

Or if you have another proposal I am all ears.

@pauladkisson
Copy link
Member

We are waiting for sleap.io to review the PR:

I'm a tad confused bc this PR updates DLC and LightningPose but not sleap.

But in general I am in favor of merging what we can, updating the CLI to isolate SLEAP and then we can re-integrate it once the PR is reviewed.

@h-mayorquin
Copy link
Collaborator Author

h-mayorquin commented Dec 16, 2024

I'm a tad confused bc this PR updates DLC and LightningPose but not sleep.

The PR does not update the code of LightingPos only the one of DLC.

  • The code of LightningPose needs to be updated
  • We need the upstream changes on sleep but for that, we can adjust on the CI temporary.

@pauladkisson
Copy link
Member

The PR does not update the code of LightingPos only the one of DLC.

Ah, I see. You're just resolving dependency conflicts with LightningPose.

Well, even better. We can update DLC in this PR and then LightningPose in the next, adding the appropriate skipifs. Then when all the ndx-pose interfaces are updated we can re-integrate the CI.

@h-mayorquin
Copy link
Collaborator Author

Yeah, that makes sense to me.

Can you review #1158? I want to merge that one then do a release. I want to do a release before merging this PR and the one in #1153 as they are both large changes on behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants