Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft deprecate file_path for SpikeGLXRecordingInterface and SpikeGLXNIDQInterface #1155

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Dec 11, 2024

As this is an important change, we are giving it a year instead of our typical six months.

Should close #978

@h-mayorquin h-mayorquin self-assigned this Dec 11, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review December 12, 2024 00:07
@bendichter
Copy link
Contributor

lgtm

…rface.py

Co-authored-by: Ben Dichter <ben.dichter@gmail.com>
@bendichter bendichter enabled auto-merge (squash) December 13, 2024 17:57
@bendichter bendichter merged commit 05423d1 into main Dec 13, 2024
40 checks passed
@bendichter bendichter deleted the deprecate_spikeglx_file_path branch December 13, 2024 19:25
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (96dfdff) to head (9e64664).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...terfaces/ecephys/spikeglx/spikeglxnidqinterface.py 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   90.69%   90.75%   +0.06%     
==========================================
  Files         129      129              
  Lines        8189     8286      +97     
==========================================
+ Hits         7427     7520      +93     
- Misses        762      766       +4     
Flag Coverage Δ
unittests 90.75% <83.33%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...terfaces/ecephys/spikeglx/spikeglxdatainterface.py 95.71% <100.00%> (+0.71%) ⬆️
...terfaces/ecephys/spikeglx/spikeglxnidqinterface.py 85.49% <66.66%> (-12.55%) ⬇️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match signature of SpikeGLXRecordingInterface interface to SpikeGLXRecordingExtractor extractor
2 participants