Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CED Recording #602

Merged
merged 8 commits into from
Oct 19, 2023
Merged

Deprecate CED Recording #602

merged 8 commits into from
Oct 19, 2023

Conversation

CodyCBakerPhD
Copy link
Member

Came up with @garrettmflynn in the GUIDE. Probably overdue

@CodyCBakerPhD CodyCBakerPhD self-assigned this Oct 17, 2023
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing on the gallery right?

@CodyCBakerPhD
Copy link
Member Author

The gallery refers to it using the non-deprecated name: https://neuroconv.readthedocs.io/en/main/conversion_examples_gallery/recording/spike2.html

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #602 (214ff88) into main (ec748f1) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   91.00%   90.78%   -0.22%     
==========================================
  Files         103      103              
  Lines        5378     5374       -4     
==========================================
- Hits         4894     4879      -15     
- Misses        484      495      +11     
Flag Coverage Δ
unittests 90.78% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/neuroconv/datainterfaces/__init__.py 100.00% <100.00%> (ø)
...tainterfaces/ecephys/spike2/spike2datainterface.py 51.85% <100.00%> (-41.70%) ⬇️

@CodyCBakerPhD CodyCBakerPhD merged commit 567213d into main Oct 19, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the deprecate_ced_name branch October 19, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants