Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumetricImagingExtractor #248

Merged
merged 13 commits into from
Oct 25, 2023
Merged

VolumetricImagingExtractor #248

merged 13 commits into from
Oct 25, 2023

Conversation

pauladkisson
Copy link
Member

Fixes #245

See also discussion in #241

@CodyCBakerPhD
Copy link
Member

I will recruit @alessandratrapani to help review this PR as well - maybe we'll go over it at the retreat?

Copy link
Collaborator

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor correction

src/roiextractors/volumetricimagingextractor.py Outdated Show resolved Hide resolved
pauladkisson and others added 2 commits October 23, 2023 18:54
Co-authored-by: Alessandra Trapani <55453048+alessandratrapani@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #248 (60e89ca) into main (e8d84bc) will increase coverage by 0.56%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   76.98%   77.55%   +0.56%     
==========================================
  Files          37       38       +1     
  Lines        2724     2793      +69     
==========================================
+ Hits         2097     2166      +69     
  Misses        627      627              
Flag Coverage Δ
unittests 77.55% <100.00%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/roiextractors/extractorlist.py 100.00% <100.00%> (ø)
src/roiextractors/testing.py 99.31% <100.00%> (+<0.01%) ⬆️
src/roiextractors/volumetricimagingextractor.py 100.00% <100.00%> (ø)

@pauladkisson pauladkisson merged commit 871552c into main Oct 25, 2023
13 checks passed
@pauladkisson pauladkisson deleted the volumetric branch October 25, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify Volumetric/MultiPlane Imaging API
4 participants