Full Dataset #12
Merged
Full Dataset #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2024
Closed
|
Note: intrinsic signal imaging and video data will be added in a future PR when I get that data from Schneider Lab. |
This was referenced Nov 20, 2024
Merged
h-mayorquin
reviewed
Nov 23, 2024
| @@ -89,14 +89,17 @@ def get_metadata_schema(self) -> dict: | |||
| } | |||
| return metadata_schema | |||
|
|
|||
| def add_to_nwbfile(self, nwbfile: NWBFile, metadata: dict): | |||
| def add_to_nwbfile(self, nwbfile: NWBFile, metadata: dict, normalize_timestamps: bool = False): | |||
There was a problem hiding this comment.
Suggestion:
When working with the convert workflow the time shifting operations have a designated place:
https://neuroconv.readthedocs.io/en/main/user_guide/temporal_alignment.html#temporal-alignment-within-nwbconverter
There was a problem hiding this comment.
Yeah... but in this case I think it would really be awkward. There's lots of different timestamps that need to be normalized to the start time, I'd have to open up the file and read it twice, and I'm not even aligning the timestamps to a different stream, just normalizing them to the appropriate start time.
src/schneider_lab_to_nwb/zempolich_2024/zempolich_2024_behaviorinterface.py
Show resolved
Hide resolved
src/schneider_lab_to_nwb/zempolich_2024/zempolich_2024_behaviorinterface.py
Show resolved
Hide resolved
src/schneider_lab_to_nwb/zempolich_2024/zempolich_2024_convert_session.py
Show resolved
Hide resolved
src/schneider_lab_to_nwb/zempolich_2024/zempolich_2024_open_ephys_recording_interface.py
Show resolved
Hide resolved
src/schneider_lab_to_nwb/zempolich_2024/zempolich_2024_open_ephys_recording_interface.py
Show resolved
Hide resolved
src/schneider_lab_to_nwb/zempolich_2024/zempolich_2024_convert_all_sessions.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds convert_all_sessions script and various small fixes.
See 4 example files here: https://drive.google.com/drive/folders/1I5_OG9KgcCskHRxIs0gHDlLGdOoEDaCM