Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video #4

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Video #4

merged 9 commits into from
Sep 9, 2024

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Sep 5, 2024 •
edited
Loading

This PR adds VideoInterface

@pauladkisson pauladkisson marked this pull request as ready for review September 7, 2024 00:12
h-mayorquin
h-mayorquin approved these changes Sep 7, 2024
View reviewed changes
Copy link

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. some questions about the metadata.

Also, can you confirm the timestamps of those cameras are aligned to the session start time? (that's always a tricky issue)

src/schneider_lab_to_nwb/schneider_2024/schneider_2024_convert_session.py Show resolved Hide resolved
src/schneider_lab_to_nwb/schneider_2024/schneider_2024_metadata.yaml Show resolved Hide resolved
@pauladkisson
Copy link
Member Author

Also, can you confirm the timestamps of those cameras are aligned to the session start time? (that's always a tricky issue)

They are probably not, but I'm going to deal with all the temporal alignment (behavior, ecephys, and video) in a separate PR.

@pauladkisson pauladkisson merged commit 8da7111 into main Sep 9, 2024
@h-mayorquin h-mayorquin deleted the video branch September 9, 2024 17:02
@pauladkisson pauladkisson mentioned this pull request Sep 10, 2024
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin h-mayorquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauladkisson @h-mayorquin