Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

fix: tooltip #243

Closed
wants to merge 2 commits into from
Closed

fix: tooltip #243

wants to merge 2 commits into from

Conversation

isabelroses
Copy link
Member

No description provided.

@nullishamy
Copy link
Contributor

Do we want to set the border colour explicitly / is it already subtext?

@isabelroses
Copy link
Member Author

Do we want to set the border colour explicitly / is it already subtext?

border seems to be set to none, border: none;.

@isabelroses
Copy link
Member Author

I got that from this command
cat ./dist/catppuccin-frappe-blue-standard+default-dark/gtk-4.0/gtk.css | rg tooltip -A8

@nullishamy
Copy link
Contributor

Hmm. We can always revisit that at a later date, seems good for now 👍

@nullishamy
Copy link
Contributor

Blocked on v1 though.

@nullishamy nullishamy added blocked priority:medium This is a medium priority issue, and should be looked at promptly. labels May 27, 2024
@isabelroses
Copy link
Member Author

Just looking into it, because it's set to none, its breaking.

@isabelroses
Copy link
Member Author

Oh the patch is also failing because mantle and etc are never set.

@isabelroses isabelroses marked this pull request as draft May 27, 2024 14:50
@isabelroses isabelroses marked this pull request as ready for review May 27, 2024 15:12
&.background {
// background-color needs to be set this way otherwise it gets drawn twice
// see https://bugzilla.gnome.org/show_bug.cgi?id=736155 for details.
- background-color: transparentize(black, 0.2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these colours are right for mocha etc. 750 is mantle, and i think we just use $white for text?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$white is a hardcoded value

+$white: #eff1f5;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but white and $white are two very different things, you have the former in this case? Did you mean to put the latter in?

patches/colloid/fix-tooltip.patch Show resolved Hide resolved
&.background {
// background-color needs to be set this way otherwise it gets drawn twice
// see https://bugzilla.gnome.org/show_bug.cgi?id=736155 for details.
- background-color: transparentize(black, 0.2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but white and $white are two very different things, you have the former in this case? Did you mean to put the latter in?

@isabelroses isabelroses mentioned this pull request May 30, 2024
@sgoudham sgoudham closed this Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority:medium This is a medium priority issue, and should be looked at promptly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants