Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed nerd-font icons #17

Closed
wants to merge 1 commit into from
Closed

fixed nerd-font icons #17

wants to merge 1 commit into from

Conversation

ronit1996
Copy link

Fixed the nerd font icons as the old ones didn't work on the updated nerd fonts, the icons are same just the names got changed in the website.

Ronit Sadhukhan
ronit1996@outlook.com

@nonetrix nonetrix mentioned this pull request Aug 31, 2023
@nonetrix
Copy link
Contributor

Is this issue present in the deathemonic version?

@nonetrix
Copy link
Contributor

nonetrix commented Aug 31, 2023

Also people can check this issue for more information. TL;DR of it is some of the Unicode codepoints used where not free for use, meaning they where already occupied so some of them where changed around to prevent issues to my best understanding

ryanoasis/nerd-fonts#1190

Perhaps this could cause issues with people with older nerd fonts versions though? Perhaps Debian or more stable distros decide not to ship it as soon, maybe a branch or separate version might need to be made

@ronit1996
Copy link
Author

I didn't check the deathmonic version but what I found out is that they had changed the codes for various icons, and hence those codes starting showing different icons.

@rhiroyuki
Copy link

rhiroyuki commented Oct 14, 2023

Running nerdfix check it alerted about some obsolete icons (for basic and the deathmonic versions).
I had to use nerdfix fix to properly display them.

@nonetrix
Copy link
Contributor

Running nerdfix check it alerted about some obsolete icons (for basic and the deathmonic versions). I had to use nerdfix fix to properly display them.

I will submit another PR with everything fixed as OP doesn't seem active

@sgoudham
Copy link

Closing as #22 supersedes this

@sgoudham sgoudham closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants